Skip to content

Fix code quality issues from V4 changes #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 29, 2019
Merged

Fix code quality issues from V4 changes #33

merged 8 commits into from
Jan 29, 2019

Conversation

ThomasKranitsas
Copy link
Contributor

Issue: #32

@sushilshinde
Copy link
Collaborator

Testing locally

ThomasKranitsas
ThomasKranitsas commented Dec 17, 2018
View reviewed changes
.gitignore Outdated
@@ -1,7 +1,7 @@
__coverage__
.build-info
.sass-cache
dist
#dist
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sushilshinde make sure to revert this line before merging ;)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@ThomasKranitsas ThomasKranitsas merged commit 8c79b42 into develop Jan 29, 2019
@ThomasKranitsas ThomasKranitsas deleted the code-quality-fixes branch January 29, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushilshinde sushilshinde Awaiting requested review from sushilshinde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasKranitsas @sushilshinde